Re: [gupnp] Introspection is here!

!iH

Nice work!

I committed the patch with some preliminary changes:

- Move introspection request function from ServiceProxy to ServiceInfo,
  because there is nothing preventing this from working server-side as
  well.

- Removed URLBase changes to ServiceProxy and DeviceProxy. Why were they
  added? The way I understand the specs, URLBase in mandatory when using
  relative URLs.

- Introspection structures are now allocated using GSlice.

- Moved class comment from header to source file for consistency.

- Re-indented introspection header to fit 80 columns.

- Removed the two added xml-util helpers, because:

   - the functionality of get_child_contents() is already provided by
     get_child_element_content().

   - has_child() was trivial and used only once.

The following still needs doing:

- Commenting of the introspection structures in a way suitable for
  gtk-doc.

- Re-indentation of service-introspection.c to fit 80 columns.

- Any pending SCPD document GETs need to be cancelled on dispose.
  (See ControlPoint for how to do this)

- Why do the ServiceIntrospection functions return copies of internal
  data? Why not return pointers to the internal structures? This would
  save a whole bunch of mallocs.

- ActionArgInfo: "char *direction" should be an enum, as we only have
  IN and OUT?

- StateVariableInfo: Rename "gtype" field to "type"?

- StateVariableInfo: Do we really need the "data_type" and "is_numeric"
  fields? This info is/should be provided by the GType field.

Let me know what you think,

Jorn

On Fri, 2007-06-29 at 18:23 +0300, ذیشان ءلی (Zeeshan Ali) wrote:
> Hey guys!
> I have completed the introspection object and it works fine with
> the two MediaServers i have on this network.
>
> Jorn!
> You might want to review the code and change a few (maybe a lot) of
> stuff, especially names of datatypes, functions and variables. If you
> don't want to get your hands dirty, just let me know and i'll do it.
> :)
>
> Matthew!
> You might want to try it with all those cool UPnP devices you have
> at your disposal. :)
>

--
To unsubscribe send a mail to gupnp+unsubscribe\@o-hand.com