Re: [gupnp] Introspection is here!

Hey!

On 6/30/07, Jorn Baayen <jorn@openedhand.com> wrote:
> > > - Re-indentation of service-introspection.c to fit 80 columns.
> >
> > I thought i already did that but I'll look into it.
>
> It's mostly done but there's still a couple of places where lines are
> wider than 80.

   I see no place where it's > 80, there are some lines where it's 80
but not more than than anywhere.

> >
> > > - Why do the ServiceIntrospection functions return copies of internal
> > > data? Why not return pointers to the internal structures? This would
> > > save a whole bunch of mallocs.

    I already did that but the thing is that i still need to give
newly-created GSlists since I am keeping things in hashtables (Look at
the action-related api to know why GSList won't be a good idea). Also
_list_actions() must allocate the GUPnPServiceActionInfo structs on
the fly so i can't get rid of those copies and the user must free the
structs along with the list. So in short, the new API saves a lot of
mallocs but doesn't look very nice (asking the user to free the list
but not the data and to free the contents as well for one function).

   Since introspection would most often be used for debugging purposes
on a desktop machine, i would prefer a simpler more readable api over
the one that saves some mallocs. What do you think?

-- 
Regards,
Zeeshan Ali
--
To unsubscribe send a mail to gupnp+unsubscribe\@o-hand.com