Re: [gupnp] Re: before the 0.2 release

On Wed, 2007-07-25 at 17:30 +0300, Zeeshan Ali wrote:
> Hey!
>
> > > * gtk-doc friendly comments on the fields of the public introspection
> > > structs.
>
> Hmm.. i think i figured on my own and the result is attached but
> don't know why all the fields of the structs are rendered on the same
> line in the resulting html, maybe a doc build bug?

You used function argument syntax there ('@'), which gtk-doc doesn't
seem to like for structures (it complains). Look at the comments on the
GtkWidget structure in gtkwidget.h to see how gtk-doc likes them.

> If you agree that your newly added comments to the struct fields
> are no more needed when there is gtk-doc comments for that struct,
> please remove those. :)

Done :)

> Also i see that you changed 'state variables' and/or 'state
> variables' in the doc comments to 'state_variable', why?

I think I'm innocent.. :) It looks like the result of some
search/replace to me. I have removed the underscores, and committed your
patch.

Cheers,

Jorn

--
To unsubscribe send a mail to gupnp+unsubscribe\@o-hand.com